[Nix-dev] Re: [Nix-commits] SVN commit: nix - 18950 - MarcWeber - in nixos/trunk: modules/installer/cd-dvd modules/installer/tools modules/installer/tools/installer2 modules/installer/tools/nixos-bootstrap-archive tests

[Marc Weber]

Excerpts from Eelco Dolstra's message of Tue Dec 15 12:40:43 +0100 2009:
> I would prefer to have big changes like this to go into a branch where they can
> be reviewed before they go into the trunk.
Well. I didn't break any existing code. So I don't see a big reason for
doing so. But yes. Reviewing some patches before comitting is a nice
idea.

Other communities (such as git :) post patches to the mailinglist and
maintainers apply them.

Flaws can be discussed in place by replying to mails. Patches are resent.

It may be easier to switch branches than applying patches in sequence
though.

But if you all think this way I will of course create a new SVN branch
for each change touching more than say 50 lines ?
 
> Also, what are the use cases for the new installer?  And what is a "bootstrap
> archive"?
This time I even pasted the README-NIXOS-BOOTSTRAP:
http://thread.gmane.org/gmane.linux.distributions.nixos/3320

I'm still waiting for an answer whether I should rewrite the passing of
lib in all-package.nix everywhere because you can access it by
stdenv.lib ?

grub defaulting to version = 1 breaking installation is most important
now. We really should fix it somehow.

Sincerly
Marc Weber