[Nix-dev] Re: [Nix-commits] SVN commit: nix - 18897 - MarcWeber - in nixpkgs/trunk/pkgs/applications/version-management/git-and-tools: . git

[Ludovic Courtès]

Hello Marc,

Marc Weber <marco-oweber at gmx.de> writes:

> You can view the changes in this commit at:
>    https://svn.nixos.org/viewvc/nix?rev=18897&view=rev
>
> Modified:
>    nixpkgs/trunk/pkgs/applications/version-management/git-and-tools/default.nix
>    nixpkgs/trunk/pkgs/applications/version-management/git-and-tools/git/default.nix
>
> Log:
> git: allow applying patches by config

[...]

> --- nixpkgs/trunk/pkgs/applications/version-management/git-and-tools/default.nix	2009-12-11 13:58:29 UTC (rev 18896)
> +++ nixpkgs/trunk/pkgs/applications/version-management/git-and-tools/default.nix	2009-12-11 13:58:31 UTC (rev 18897)
> @@ -15,6 +15,7 @@
>      svnSupport = getConfig ["git" "svnSupport"] false; # for git-svn support
>      guiSupport = getConfig ["git" "guiSupport"] false;
>      perlLibs = [perlPackages.LWP perlPackages.URI perlPackages.TermReadKey subversion];
> +    additionalPatches = getConfig ["git" "additionalPatches"] [];

FWIW I find it very specific and mostly useless, based on the assumption
that:

  1. Either you’re a Git “end-user” and just use whichever upstream
     version is available in Nixpkgs and works for you.

  2. Or you’re a Git developer and you get a local clone of the upstream
     Git repo where you actually work.

Thus, I’d refrain from adding this additional parameter.

What do you think?

Thanks,
Ludo’.