[Nix-dev] Re: [Nix-commits] SVN commit: nix - 16844 - raskin - in nixpkgs/trunk/pkgs: applications/misc/gphoto2 top-level

[Eelco Dolstra]

Hi,

Michael Raskin wrote:

> Eelco Dolstra wrote:
>> Another point to consider: the platforms on which we want to build a package in
>> Hydra is not an inherent property of the package, but a part of the Hydra
>> configuration.  (You might want to run your own Hydra instance and build some
>> subset of Nixpkgs on different platforms...) So they should be specified in
>> release.nix, not in the Nix expression for the package.
> 
> We may say that the package is supposed to work on some platforms (it
> doesn't make sense to expect xscreensaver work on cygwin). We may build
> some packages on all their supported platforms that are also supported
> by hydra. One may want or may not want to apply this logic to all
> packages with maintainer and platform specified..

Yes, that's true.  If we have a meta.supportedPlatforms attribute, then it's a
good default strategy to let Hydra build the package on all those platforms
unless overriden in release.nix.

> Do you think that te first approach will quickly lead to undue load for
> Hydra?

No, it's not a problem.  If so we'll add more hardware ;-)

>> This turns out not to be the case.  For instance, if a package has a dependency
>> "foo" containing an attribute "bar", it might evaluate "foo.bar".  This will
>> barf if foo is {}.
> 
> OK, platformPackage/condPackage/... is not needed now. tryEval is more
> than enough.

Right, that was my main object.  A meta attribute


-- 
Eelco Dolstra | http://www.st.ewi.tudelft.nl/~dolstra/