[Nix-dev] Re: [Nix-commits] SVN commit: nix - 14913 - sandervanderburg - in nixos/trunk: system upstart-jobs

[Nicolas Pierron]

Hi Sander,

If I understand your commit well, you have duplicated most of the
content of xserver.nix to copy it inside kdm.nix.  I guessing that the
reason you made this copy & paste is that the upstart-job describe in
xserver.nix is a job which is starting Slim.

If you have a look at the fix-style branch, you may see that the
xserver.nix file no longer exists.  This file is divided into many
subset which allow you to keep things separated between displayManager
/ windowManager / desktopManager.

I have to admit that I don't know how to merge your commit inside the
fix-style branch because there is too much differences and I haven't
look at KDM yet.  On the other hand you may find pretty-straight
forward to add KDM in the fix-style branch.

As the fix-style branch is pending to be merged, I think your
comparison could be a useful feedback for all of us.  Either this
would be a failure for some reasons (that I am expecting you to find)
or this would be a success in which case your experience will be
valuable for sceptical person.

Sincerly,

On Tue, Apr 7, 2009 at 17:34, Sander van der Burg
<S.vanderBurg at tudelft.nl> wrote:
> Added very experimental KDM support
>
> Changes:
>
> Modified: nixos/trunk/system/options.nix
> ===================================================================
> --- nixos/trunk/system/options.nix      2009-04-07 15:12:12 UTC (rev 14912)
> +++ nixos/trunk/system/options.nix      2009-04-07 15:33:59 UTC (rev 14913)
> @@ -1191,6 +1191,15 @@
>       };
>     };
>
> +    kdm = {
> +
> +      enable = mkOption {
> +        default = false;
> +        description = "
> +          Whether to enable the KDE display manager.
> +        ";
> +      };
> +    };
>
>     xserver = {
>
> Added: nixos/trunk/upstart-jobs/kdm.nix
> ===================================================================
> --- nixos/trunk/upstart-jobs/kdm.nix                            (rev 0)
> +++ nixos/trunk/upstart-jobs/kdm.nix    2009-04-07 15:33:59 UTC (rev 14913)
> @@ -0,0 +1,269 @@
> + # ...
> + # A huge part coming from xserver.nix
> + # ...



-- 
Nicolas Pierron
http://www.linkedin.com/in/nicolasbpierron
- If you are doing something twice then you should try to do it once.