[Nix-dev] Re: [Nix-commits] SVN commit: nix - 13344 - MarcWeber - in [..]

[Marc Weber]

On Wed, Nov 19, 2008 at 11:54:08PM +0100, Ludovic Courtès wrote:
> Hello,
> 
> Marc Weber <marco-oweber at gmx.de> writes:
> 
> > Author: MarcWeber
> > Date: 2008-11-19 21:46:01 +0000 (Wed, 19 Nov 2008)
> > New Revision: 13344
> >
> > You can view the changes in this commit at:
> >    https://svn.nixos.org/viewvc/nix?rev=13344&view=rev
> >
> > Added:
> >    nixpkgs/trunk/pkgs/development/libraries/gstreamer/gst-plugins-base/0.10.21.nix
> >    nixpkgs/trunk/pkgs/development/libraries/gstreamer/gst-plugins-good/0.10.11.nix
> >    nixpkgs/trunk/pkgs/development/libraries/gstreamer/gstreamer/0.10.21.nix
> 
> Any reason why several versions must be kept?
I'll remove them in some days when nobody complains.. I haven't checked
wether everything builds.

> 
> > +    inherit (gnome) gnomevfs /* <- only passed for the no longer used older versions
> > +             it is depreceated and didn't build on amd64 due to samba dependenccy */ gtkdoc;
> 
> I don't understand this sentence.  Also, I find it inappropriate to tell
> stories in the middle of the code.
Sorry, the sentence should have told you that gnomevfs is only used by the
dangling files. It can be removed with them. I didn't know wether
someone needs the samba and gnomevfs features.. Again if nobody
complains I'll remove gnomevfs and the comment soon.

Marc