[Nix-dev] Re: [Nix-commits] SVN commit: trace - 11141 - MarcWeber - in nixos/trunk: system upstart-jobs

[Ludovic Courtès]

Hi Marc,

Marc Weber <marco-oweber at gmx.de> writes:

> Author: MarcWeber
> Date: 2008-03-16 01:05:40 +0000 (Sun, 16 Mar 2008)
> New Revision: 11141
>
> You can view the changes in this commit at:
>    https://svn.cs.uu.nl:12443/viewvc/trace?rev=11141&view=rev
>
> Modified:
>    nixos/trunk/system/options.nix
>    nixos/trunk/system/system.nix
>    nixos/trunk/upstart-jobs/default.nix
>    nixos/trunk/upstart-jobs/httpd.nix
>
> Log:
> added mkOption extraConfig for httpd apache service 
>     ( added \n in config concatenation as well )

This change is unrelated to the rest of the change set.  It's better to
commit only logically related changes in a single change set.

> added serviceProposal, examples see upstart-jobs/newProposal/*.nix

There's no `newProposal' directory AFAICS.  Besides, remember that camel
case should not be used for file names: use hyphens and lower case
instead---I think I'll end up adding it to my `.signature'.  ;-)

The whole change looks intrusive to me: we get a `system.nix' that
includes your "new proposal" alongside the current mechanism, which
looks a bit messy IMO.

FWIW, I would have preferred it if you had developed your proposal
independently in another branch that we can look at to evaluate your new
proposal without disturbing `trunk'; if/when we agree that your proposal
is the Right Thing, we can merge the branch all at once into trunk.

Thanks,
Ludovic.