[Nix-dev] Re: [submission] adns-1.4

[Ludovic Courtès]

Hello,

As Nicolas already said, your package looks good.  A few nitpicks:

Peter Simons <simons at cryp.to> writes:

> {stdenv, fetchurl, static ? false}:
>
> stdenv.mkDerivation {
>   name = "adns-1.4";
>   src = fetchurl {
>     url = ftp://ftp.chiark.greenend.org.uk/users/ian/adns/adns-1.4.tar.gz;

Since this is a GNU package, you can use the `mirror' scheme: Nixpkgs
knows a list of GNU mirrors, so it can try any of them when you do it.

  url = mirror://gnu/adns/adns-1.4.tar.gz;

>     md5 = "88bc7bbf3f62a8d4fb186b8f72ead853";

I think it's usually better to use the sha256 hash now, preferably
base32-encoded.  The `nix-prefetch-url' tool helps you do this.

Besides, if you plan to keep contributing to Nix, you may want to ask
for a Subversion account (email Eelco Dolstra for this).

Thanks,
Ludovic.